Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor manifest #572

Conversation

ruben-arts
Copy link
Contributor

@ruben-arts ruben-arts commented Dec 15, 2023

Refactoring the Project into Manifest

This is done to split the responsibilities.

Built to close #577

@ruben-arts ruben-arts requested review from baszalmstra, tdejager and wolfv and removed request for baszalmstra December 15, 2023 14:16
Copy link
Member

@wolfv wolfv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff. Left some comments

src/project/mod.rs Outdated Show resolved Hide resolved
tests/common/mod.rs Show resolved Hide resolved
src/project/manifest.rs Outdated Show resolved Hide resolved
src/project/manifest.rs Outdated Show resolved Hide resolved
src/project/manifest.rs Outdated Show resolved Hide resolved
src/project/manifest.rs Show resolved Hide resolved
tests/common/mod.rs Show resolved Hide resolved
@ruben-arts ruben-arts merged commit c211842 into prefix-dev:main Dec 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the manifest code to contain all modification
4 participants