refactor: move code from Project to Environment
#630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-arts
approved these changes
Jan 8, 2024
|
@github, Please just automerge this, why doesn't that work anymore 😠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the code to extract project information from
Environments instead of directly from the project.This initial PR tries to retain the same surface level API as before where the accessors on the
Projectstruct remains intact.A next PR will remove this functions and force users to go through
Environments instead ofProject.This PR currently refactos the
platforms,channelsandtasksfunctions. I will create a follow-up PRs to also refactor thesystem-requirements,activationanddependencyfunctions.