Remove dependency from feature through cli #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Jan 17, 2024
baszalmstra
reviewed
Jan 18, 2024
src/project/manifest/mod.rs
Outdated
| @@ -308,15 +308,13 @@ impl Manifest { | |||
| dep: &PackageName, | |||
| spec_type: SpecType, | |||
| platform: Option<Platform>, | |||
| feature_name: Option<&FeatureName>, | |||
There was a problem hiding this comment.
I think you can use the same logic here. I think the user should always pass a feature name. Its either the default or a named one.
There was a problem hiding this comment.
Ah yeah, changed that in d8dbc95
wolfv
changed the title
baszalmstra
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
--feature FEATURENAMEto thepixi removecommand.Did this one first as it is probably one of the simplest commands to modify. To prepare for the full multi env integration.