Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: download wheels in parallel to avoid deadlock #752

Merged
merged 2 commits into from
Feb 1, 2024
Merged

fix: download wheels in parallel to avoid deadlock #752

merged 2 commits into from
Feb 1, 2024

Conversation

baszalmstra
Copy link
Contributor

This paralellizes the download/building of wheels (vs concurrent) to avoid a deadlock issue we encountered.

@ruben-arts
Copy link
Contributor

Test with:

cd examples/pypi
rm ~/.cache/rattler/cache/pypi/ .pixi -r && pixi i

tdejager
tdejager approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@tdejager tdejager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ill try making a PR later to remove all WheelBuilder lifetimes so this becomes a bit easier as well.

src/install_pypi.rs Outdated Show resolved Hide resolved
ruben-arts
ruben-arts approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ruben-arts ruben-arts merged commit 5e88db8 into prefix-dev:main Feb 1, 2024
9 checks passed
@zuisong zuisong mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruben-arts ruben-arts ruben-arts approved these changes

@tdejager tdejager tdejager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baszalmstra @ruben-arts @tdejager