-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add env
to the tasks to specify tasks specific environment variables
#972
Conversation
@wolfv Do you want to continue on this pr? other wise making an issue out of it and closing it would be nice. |
I like this, a lot actually. A few questions:
|
env
to the tasks to specify tasks specific environment variables
env
to the tasks to specify tasks specific environment variablesenv
to the tasks to specify tasks specific environment variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for pushing. Also love the idea about using env vars as "positional arguments" and for task parameterization.
Just one note about the order of env vars.
If I could, I would approve the PR (since I opened it I can't review!) :) |
This adds the ability to set additional environment variables for a specific task. E.g.:
This results in:
We might also want this for a feature / environment (as a lightweight way of adding an 'activation script').
TODO:
test
task.