Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use gitignore when copying the recipe files #1193

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Nov 14, 2024

No description provided.

@tdejager
Copy link
Contributor

Just tried it on this: prefix-dev/pixi-build-backends#9

And the result are smaller binaries, in comparison the previous ones were like 300mb
image

@wolfv
Copy link
Member Author

wolfv commented Nov 14, 2024

Did you analyze the output? It should print all the files that are part of the package.

@tdejager
Copy link
Contributor

Yeah actually, it does still seem to include the .git itself. The rest is okay. .git by itself is not included in the gitignore, is this something to exclude manually?

image

@wolfv
Copy link
Member Author

wolfv commented Nov 14, 2024

We can add .hidden(true) and then that would also be ignored.

@tdejager
Copy link
Contributor

Sounds good!

@tdejager
Copy link
Contributor

LGTM!:

image

@wolfv wolfv enabled auto-merge (squash) November 14, 2024 11:16
@wolfv wolfv merged commit f6e5409 into prefix-dev:main Nov 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants