Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --channel-priority={strict|disabled} #1211

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

tl-hbk
Copy link
Contributor

@tl-hbk tl-hbk commented Nov 22, 2024

I needed a way to change the channel priority due to having a similar situation as the op of this issue #343

I'm new to rust so there's probably a better way of adding it as a cli arg without the wrapper but I couldn't figure it out

src/opt.rs Outdated Show resolved Hide resolved
@wolfv
Copy link
Member

wolfv commented Nov 23, 2024

Looks good to me! Left one small comment.

@tl-hbk
Copy link
Contributor Author

tl-hbk commented Nov 25, 2024

@wolfv it looks like some workflows need to be approved before they can run. Could you approve those?

@wolfv
Copy link
Member

wolfv commented Nov 26, 2024

For some weird reason the button to run the tests does not show up. Can you push an empty commit?

@tl-hbk
Copy link
Contributor Author

tl-hbk commented Nov 26, 2024

For some weird reason the button to run the tests does not show up. Can you push an empty commit?

done

@wolfv
Copy link
Member

wolfv commented Nov 26, 2024

OK, finally CI is running! :)

@wolfv wolfv merged commit 586982d into prefix-dev:main Nov 27, 2024
15 checks passed
@tl-hbk tl-hbk deleted the channel_priority branch November 27, 2024 15:06
@happysalada
Copy link

Hi was there a specific test with channel priority disabled ?
Im still getting "is excluded because due to strict channel priority not using this"

I am specifying several channels as arguments from the cli, could that be the problem ?

@tl-hbk
Copy link
Contributor Author

tl-hbk commented Dec 13, 2024

I didn't add a test to the repo but after the new version was released I tested it also using several channels as cli args and it worked fine for me

rattler-build build -r <recipe> -c <channel 1> -c <channel 2> --channel-priority disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants