-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --channel-priority={strict|disabled}
#1211
Conversation
Looks good to me! Left one small comment. |
c40275b
to
20eb099
Compare
@wolfv it looks like some workflows need to be approved before they can run. Could you approve those? |
For some weird reason the button to run the tests does not show up. Can you push an empty commit? |
done |
OK, finally CI is running! :) |
Hi was there a specific test with channel priority disabled ? I am specifying several channels as arguments from the cli, could that be the problem ? |
I didn't add a test to the repo but after the new version was released I tested it also using several channels as cli args and it worked fine for me
|
I needed a way to change the channel priority due to having a similar situation as the op of this issue #343
I'm new to rust so there's probably a better way of adding it as a cli arg without the wrapper but I couldn't figure it out