Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: git source with host git #269

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Conversation

swarnimarun
Copy link
Contributor

@swarnimarun swarnimarun commented Nov 9, 2023

TODO:

  • Create the POC for host git.
  • Get the code working on unix systems at least.
  • Add basic unit tests from git_source to host git source.
  • Refactor the code, remove redundant code, remove unwraps, improve error messages and reporting.
  • Remove feature git, and ensure CI runs work.
  • Handle lack of git or git-lfs gracefully.
  • Write E2E test.
  • Windows path issues (too vague to list, out of 3 tests, last one is broken on windows, perhaps 2/3 is a good thing?)...
  • Fix bugs on all platforms.
  • Look into why conda-build performs "mirror", and if we should consider mirrors as well.

TODO in a separate PR:

  • Figure out and ensure ssh auth works by default on all platforms with all configurations.
  • Use mirrored clones over normal clones.
  • Write tests for all aspects (clone from git path, non-standard revs(hash, tags, branches, etc), use of cache, etc.)

@swarnimarun swarnimarun self-assigned this Nov 9, 2023
@swarnimarun swarnimarun marked this pull request as ready for review November 14, 2023 08:46
@swarnimarun swarnimarun requested a review from wolfv November 14, 2023 08:54
@swarnimarun
Copy link
Contributor Author

This has both unit and E2E tests, but I am doing some user testing of my own, to test out all the features, will create a separate PR with more E2E tests or add more cases to the present E2E test.

@wolfv wolfv merged commit 1bd5d9a into prefix-dev:main Nov 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants