Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error if git rev and git depth are used together #340

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

swarnimarun
Copy link
Contributor

No description provided.

@wolfv
Copy link
Member

wolfv commented Nov 22, 2023

LGTM as discussed on Discord, might be good to add a check also when fetching the git source, so that GitSrc created from other places (e.g. future Python bindings) also error out properly.

@swarnimarun swarnimarun marked this pull request as ready for review November 22, 2023 10:58
@swarnimarun swarnimarun requested a review from wolfv November 22, 2023 10:58
src/source/git_source.rs Outdated Show resolved Hide resolved
@wolfv wolfv merged commit 1e015ec into prefix-dev:main Nov 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants