feat: uploading to prefix.dev #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xbe7a
reviewed
Dec 19, 2023
src/upload.rs
Outdated
| println!("Upload successful!"); | ||
| } else { | ||
| println!("Upload failed!"); | ||
| if response.status() == 401 { |
There was a problem hiding this comment.
|
@0xbe7a I refactored the code a little bit and added progress bars to each of the methods. Do you think you can test this for quetz & artifactory? This also allows to put more than a single package for uploading, e.g.
|
0xbe7a
reviewed
Dec 21, 2023
src/upload.rs
Outdated
| let index_json = IndexJson::from_package_directory(package_dir.path()).into_diagnostic()?; | ||
| let subdir = index_json | ||
| .subdir | ||
| .ok_or_else(|| miette::miette!("index.json of the package has no subdirectory. Cannot determine which directory to upload to"))?; |
There was a problem hiding this comment.
We should include the package name in the error message
|
Looks good, i will test the Quetz and Artifactory upload later today |
|
OK, let me know how it goes and then I'll merge :) |
|
Works as advertised, ready to merge! 🤠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.