Add 'Default', 'Dwarf' and 'SplitDwarf' arguments to 'debugformat' #1067

ratzlaff · 2018-04-25T05:54:33Z

Adds 'Default', 'Dwarf' and 'SplitDwarf' options to 'debugformat' when using the xcode, gmake or gmake2 modules.

Wiki updates are at: https://github.com/ratzlaff/premake-core/wiki/debugformat
wiki repo URL: https://github.com/ratzlaff/premake-core.wiki.git (branch: xcode_debugformat)

starkos

This looks good, thanks! Should we be adding the dwarf debug formats to _premake_init.lua though to make them accessible to GCC, etc.?

ratzlaff · 2018-04-25T18:47:07Z

I was not familiar with the debug formats that gcc handles, which is the only reason I did not put them in _premake_init.lua. I thought this would be better encapsulation for the module-specific parameters.

After looking over the debug options for gcc though, it makes sense to emit -gdwarf when present. I'll update my PR when I can later.

starkos · 2018-04-26T15:39:19Z

Xcode uses Clang under the hood, so Clang must support them at least?

ratzlaff · 2018-04-27T05:34:08Z

rebased onto master

samsinsane · 2018-04-27T06:33:08Z

modules/xcode/_preload.lua

@@ -40,6 +40,10 @@
 		}
 	}

+	p.api.addAllowed("debugformat", {
+		"dwarf-with-dsym",


There's a similar option on Linux that does the same thing, it's called something else though. Given that they're the same thing, but have different names, it would be good to use generic terminology - I believe dsym is very much an Apple term, I only got macOS hits when I googled it the other night.

The idea here was to not introduce a layer of mapping between premake values and what is generated in the xcode project file (ie: what you enter is what you get).

I (mistakenly) thought that by adding to debugformat in the xcode action, those options would not be available outside of the module, whoops!

It looks like the equivalent gcc flag is be -gsplit-dwarf. Ill make that the value instead.

starkos · 2018-04-27T18:45:55Z

Another option is to make "dwarf-with-dsym" an alias of "split-dwarf", or vice versa.

ratzlaff · 2018-04-27T18:53:47Z

@starkos I just squashed some commits just now to do that. Updating my copy of the documentation now...

TurkeyMan

This could generate bad makefiles if the premake script is also intended for windows, and the filter's aren't manual-enough.

TurkeyMan · 2018-05-05T03:40:53Z

src/tools/gcc.lua

-		},
+		symbols = function(cfg, mappings)
+			local debugformat = cfg.debugformat or ""
+			return { On = "-g" .. debugformat }


What does -gc7 mean?

TurkeyMan · 2018-05-05T03:50:52Z

I feel like there probably needs to be a Default value allowed here too, and all the allowed values have a weird lower-case convention. This is unlike any other API in premake, especially with the - separator, which may cause inconveniences with lua syntax when indexing explicitly.
I think there should probably be Default, C7, Dwarf, SplitDwarf, and map them to proper values in the function (ignoring C7 for GCC)

ratzlaff · 2018-05-07T05:38:02Z

Added 'Default', changed capitalization of values, added more tests for 'Default'.

Did not change c7 to C7 - should be a separate PR to properly deprecate the flag.

TurkeyMan · 2018-05-07T20:51:32Z

src/tools/gcc.lua

+		symbols = function(cfg, mappings)
+			local values = gcc.getdebugformat(cfg)
+			local debugformat = values[cfg.debugformat] or ""
+			return { On = "-g" .. debugformat }


Is it a supported feature that we return a table from this function?
I thought this function was just meant to return the options string (the value part)...?

Assuming this works, it should also support FastLink and Full values for symbols. Docs allege that if they are undefined for a platform, they are a synonym for On.

Returning a table from this function is to preserve as much of the existing behavior prior to this change as possible.

The test for 'function' type and executing the function here is what triggers this logic to take place.

Ah. I see what you mean about FastLink and Full. Will add those in when I get home later.

TurkeyMan · 2018-05-07T20:53:29Z

Sorry to push back on this again, but symbols is such a fundamental API ;)
I recognise that the code was already stale (only On was present in the code before you modified it), but this is a good opportunity to de-stale it ;)

ratzlaff · 2018-05-09T00:07:02Z

@TurkeyMan Next iteration ready to go!

samsinsane · 2018-08-10T05:49:44Z

@TurkeyMan are you happy with the latest changes?

tdesveauxPKFX · 2018-11-12T18:45:30Z

I think all concerns @TurkeyMan had were addressed and this was not updated in a while.

I think this is a nice addition and looking through the changes feels fine with merging.
Should we override the pending requested changes?

samsinsane · 2018-11-13T08:02:49Z

@tdesveauxPKFX I'm happy for this to go in, I think we've let this PR stagnate for long enough. If there's problems, we can just address them as they pop up.

…make and gmake2 tests

samsinsane · 2019-01-11T02:59:35Z

I'm just going to merge this now, thanks for fixing it up multiple times! Sorry it's taken so long to get this through.

ratzlaff · 2019-01-11T14:31:49Z

Thanks!

tvandijck approved these changes Apr 25, 2018

View reviewed changes

starkos reviewed Apr 25, 2018

View reviewed changes

ratzlaff force-pushed the xcode_debugformat branch 3 times, most recently from 36ef3a6 to 4c4c7b5 Compare April 27, 2018 05:29

ratzlaff changed the title ~~update xcode module to support more inputs to 'debugformat'~~ update modules (xcode, gmake, gmake2) to support more inputs to 'debugformat' Apr 27, 2018

samsinsane reviewed Apr 27, 2018

View reviewed changes

ratzlaff force-pushed the xcode_debugformat branch from 4c4c7b5 to 3f5b1ff Compare April 27, 2018 18:46

ratzlaff changed the title ~~update modules (xcode, gmake, gmake2) to support more inputs to 'debugformat'~~ Add 'dwarf' and 'split-dwarf' arguments to 'debugformat' Apr 27, 2018

ratzlaff force-pushed the xcode_debugformat branch from 3f5b1ff to e99e2a7 Compare May 2, 2018 05:19

TurkeyMan suggested changes May 5, 2018

View reviewed changes

ratzlaff force-pushed the xcode_debugformat branch from e99e2a7 to 7acbd5f Compare May 7, 2018 05:34

ratzlaff changed the title ~~Add 'dwarf' and 'split-dwarf' arguments to 'debugformat'~~ Add 'Default', 'Dwarf' and 'SplitDwarf' arguments to 'debugformat' May 7, 2018

ratzlaff force-pushed the xcode_debugformat branch from 7acbd5f to 95d1c02 Compare May 7, 2018 05:39

TurkeyMan suggested changes May 7, 2018

View reviewed changes

ratzlaff force-pushed the xcode_debugformat branch from 95d1c02 to 9c07782 Compare May 8, 2018 04:24

ratzlaff force-pushed the xcode_debugformat branch from 9c07782 to 4602d63 Compare May 16, 2018 04:37

ratzlaff force-pushed the xcode_debugformat branch from 4602d63 to 1f60a1f Compare November 7, 2018 03:19

ratzlaff force-pushed the xcode_debugformat branch from 1f60a1f to a364392 Compare November 13, 2018 03:54

ratzlaff added 2 commits November 17, 2018 18:45

Add 'Default', 'Dwarf' and 'SplitDwarf' inputs to 'debugformat'

da90c1f

Handle 'Full' and 'FastLink' arguments to 'symbols'. Add associated g…

85ed6bb

…make and gmake2 tests

ratzlaff force-pushed the xcode_debugformat branch from a364392 to 85ed6bb Compare November 18, 2018 01:45

samsinsane merged commit 1d469fc into premake:master Jan 11, 2019

ratzlaff deleted the xcode_debugformat branch January 11, 2019 14:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'Default', 'Dwarf' and 'SplitDwarf' arguments to 'debugformat' #1067

Add 'Default', 'Dwarf' and 'SplitDwarf' arguments to 'debugformat' #1067

ratzlaff commented Apr 25, 2018 •

edited

Loading

starkos left a comment

ratzlaff commented Apr 25, 2018 •

edited

Loading

starkos commented Apr 26, 2018

ratzlaff commented Apr 27, 2018

samsinsane Apr 27, 2018

ratzlaff Apr 27, 2018

starkos commented Apr 27, 2018

ratzlaff commented Apr 27, 2018

TurkeyMan left a comment

TurkeyMan May 5, 2018

TurkeyMan commented May 5, 2018

ratzlaff commented May 7, 2018 •

edited

Loading

TurkeyMan May 7, 2018

ratzlaff May 7, 2018

ratzlaff May 7, 2018

TurkeyMan commented May 7, 2018

ratzlaff commented May 9, 2018

samsinsane commented Aug 10, 2018

tdesveauxPKFX commented Nov 12, 2018

samsinsane commented Nov 13, 2018

samsinsane commented Jan 11, 2019

ratzlaff commented Jan 11, 2019

Add 'Default', 'Dwarf' and 'SplitDwarf' arguments to 'debugformat' #1067

Add 'Default', 'Dwarf' and 'SplitDwarf' arguments to 'debugformat' #1067

Conversation

ratzlaff commented Apr 25, 2018 • edited Loading

starkos left a comment

Choose a reason for hiding this comment

ratzlaff commented Apr 25, 2018 • edited Loading

starkos commented Apr 26, 2018

ratzlaff commented Apr 27, 2018

samsinsane Apr 27, 2018

Choose a reason for hiding this comment

ratzlaff Apr 27, 2018

Choose a reason for hiding this comment

starkos commented Apr 27, 2018

ratzlaff commented Apr 27, 2018

TurkeyMan left a comment

Choose a reason for hiding this comment

TurkeyMan May 5, 2018

Choose a reason for hiding this comment

TurkeyMan commented May 5, 2018

ratzlaff commented May 7, 2018 • edited Loading

TurkeyMan May 7, 2018

Choose a reason for hiding this comment

ratzlaff May 7, 2018

Choose a reason for hiding this comment

ratzlaff May 7, 2018

Choose a reason for hiding this comment

TurkeyMan commented May 7, 2018

ratzlaff commented May 9, 2018

samsinsane commented Aug 10, 2018

tdesveauxPKFX commented Nov 12, 2018

samsinsane commented Nov 13, 2018

samsinsane commented Jan 11, 2019

ratzlaff commented Jan 11, 2019

ratzlaff commented Apr 25, 2018 •

edited

Loading

ratzlaff commented Apr 25, 2018 •

edited

Loading

ratzlaff commented May 7, 2018 •

edited

Loading