Xcode newid determinism #1253
Merged
Xcode newid determinism #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsinsane
requested changes
Mar 8, 2019
Update unit tests with hashcode instead of overridden xcode.newid implementation
ratzlaff
force-pushed
the
xcode_newid_determinism
branch
from
4121ec7
to
b17b17a
Compare
samsinsane
approved these changes
Mar 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the ability to generate the exact same xcodeproj from different environments
Prior to this change, the absolute path held in node.path passed into xcode.newid would create different id's depending on where the project was located on your filesystem (especially visible when creating projects on windows and comparing the same project generated from a mac)
Since this path was the third item passed into xcode.newid, it was not visible to the existing tests. Some tests have been updated to show the new relative path being used to generate the id.