Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Lua from 5.3.4 to 5.3.5 #1340

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Conversation

jp31415926
Copy link
Contributor

What does this PR do?

Simple patch to upgrade Lua to 5.3.5. I have had no problems with this upgrade in my other lua projects and I don't expect you to have any issues as well.

How does this PR change Premake's behavior?

There should be no change functionally. The changes made were mostly internal and don't appear to be breaking changes. The changes that premake made to lauxlib.c and liolib.c were maintained.

pretest5 test was executed after this change and passed all tests.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not overly clear what we gain from upgrading? But thanks for doing this!

@samsinsane samsinsane merged commit 1a8bd06 into premake:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants