E2K: fixed build by MCST lcc compiler #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed build by MCST lcc compiler on MCST Elbrus 2000 architecture when using Curl - strip UTF-8 BOM for compability with MCST lcc compiler < 1.24
|
My changes were accepted in the main branch of Curl. |
samsinsane
approved these changes
Nov 10, 2019
There was a problem hiding this comment.
This seems fine to me, @starkos should we merge this or grab latest curl instead?
|
Seems to make more sense to just grab the new curl? I don't recall exactly what hoops we need to jump through when we do that though… |
|
There are differences in file structure between these versions of Curl (for example, curlbuild.h in the old version and system.h in the new version seem similar to each other). But in any case, please remove BOM (Byte Order Mark) from src/host/curl_utils.c file. MCST lcc compiler version < 1.24 does not understand BOM. |
|
Okay, guess it makes sense to get this merged now then. Thanks for the contribution! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How does this PR change Premake's behavior?
This PR doesn't change Premake's behaviour to the end user.
Anything else we should know?
e2k (Elbrus 2000) - this is VLIW/EPIC architecture, like Intel Itanium architecture.
About this architecture:
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!