Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up and improve the release docs and script #1427

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

starkos
Copy link
Member

@starkos starkos commented Apr 21, 2020

What does this PR do?

Fixes a few bits of the packaging script that weren't working properly, and reviewed and cleaned up the supporting checklist. Just getting my head around the process again before cutting a new release.

How does this PR change Premake's behavior?

It does not. Packaging & checklist fixes only.

Anything else we should know?

Nope.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass n/a
  • Mention any related issues n/a
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FWIW, I believe the GitHub Actions allow us to automate the packages a bit, but the documentation on how is a bit lacking.

@samsinsane samsinsane merged commit 012c341 into master Apr 22, 2020
@samsinsane samsinsane deleted the release-improvements branch April 22, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants