Remove moduledownloader to avoid RCE. #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsinsane
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This removes
moduledownloaderfunctionality which is used to download missing modules from a remote server (defaultpackagesrv.com).How does this PR change Premake's behavior?
Premake will no longer attempt to download missing modules.
Anything else we should know?
The domain that
moduledownloaderis pinging and grabbing missing modules from (packagesrv.com) had lapsed and expired,moduledownloaderis implemented in such a fashion that it does not securely download and install modules. This would lead to a remote code execution. @JoelLinn has registered the domain to prevent any bad actors from taking advantage of this situation, but this is only a bandaid fix.Please refer to #1381.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)