Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix author name and update time on pages #1644

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Conversation

KyrietS
Copy link
Member

@KyrietS KyrietS commented Jun 10, 2021

What does this PR do?

Currently, every page has the same author and update time.

image

The problem is that actions/checkout@v2 fetches only last commit by default but docusaurus needs to know about every file's history to generate proper metadata. This PR fixes the issue.

with:
  fetch-depth: 0

this tells actions/checkout@v2 to fetch all commits, all branches, all tags, etc.

Working demo: here

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@starkos starkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, thanks!

@starkos starkos merged commit cb09eca into premake:master Jun 10, 2021
@KyrietS
Copy link
Member Author

KyrietS commented Jun 10, 2021

Oh, and this change of course didn't trigger website rebuild 😅
I think it's not critical fix so we can wait for some other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants