Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make clean handling of generated files #1763

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

starkos
Copy link
Member

@starkos starkos commented Nov 26, 2021

What does this PR do?

Replaces an incorrect rmdir with del to fix removal of generated files on make clean. Closes #1650.

How does this PR change Premake's behavior?

No changes other than the fix.

Anything else we should know?

Nope.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rm -rf above on line 689, should be changed to rm -f to match the change here. This can still be merged, but I think this will create confusion around exactly what $(GENERATED) contains.

@starkos starkos merged commit 132249e into premake:master Jan 4, 2022
@starkos starkos deleted the issue/1650 branch January 4, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make clean is not working with generated files
2 participants