Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openmp for xcode. #1894

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Fix openmp for xcode. #1894

merged 1 commit into from
Jun 21, 2022

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Jun 9, 2022

What does this PR do?

pass -fopenmp in xcode generator when openmp "On" is provided

How does this PR change Premake's behavior?

xcode generator only

Anything else we should know?

MacOSX seems to need special install of gcc to have that flag accepted.
I didn"t have courage to do it for premake-sample-projects
so https://github.com/Jarod42/premake-sample-projects/actions/runs/2469814949 still fails my test
but flag is present in command line.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you also update the docs for the openmp API to list XCode support in beta2?

@Jarod42
Copy link
Contributor Author

Jarod42 commented Jun 10, 2022

Doc updated.

@Jarod42
Copy link
Contributor Author

Jarod42 commented Jun 10, 2022

Failing tests on macosx seems to be (temporary) connexion errors.
unrelated to the PR.

[  FAILED  ] 2 tests, listed below:
[  FAILED  ] vs2010_ensure_nuget_imports.structureIsCorrect
[  FAILED  ] vs2010_extension_targets.addsImport_onEachNuGetPackage

** Error: NuGet API error (0)
SSL connect error
unction 'testFunction'

@samsinsane samsinsane merged commit 1c22240 into premake:master Jun 21, 2022
@Jarod42 Jarod42 deleted the OpenMPForXcode branch July 14, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants