Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vstudio: add usestandardpreprocessor option #1952

Merged

Conversation

flakey5
Copy link
Contributor

@flakey5 flakey5 commented Sep 8, 2022

What does this PR do?

Adds the usestandardpreprocessor option for Visual Studio. Tells msbuild to use a standard-conforming preprocessor.

How does this PR change Premake's behavior?

Doesn't really change much, just adds another config option.

Anything else we should know?

Nope

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@Jarod42
Copy link
Contributor

Jarod42 commented Sep 8, 2022

Shouldn't src/tools/msc.lua be updated too.

@flakey5
Copy link
Contributor Author

flakey5 commented Sep 9, 2022

Ah yeah, thanks for pointing that out. Added it to there as well.

@flakey5 flakey5 force-pushed the flakey5/add-usestandardpreprocessor branch from 75432bc to 6898ee2 Compare September 21, 2022 00:21
@flakey5
Copy link
Contributor Author

flakey5 commented Sep 21, 2022

Force pushed to squash commits

@samsinsane samsinsane merged commit 7d241a6 into premake:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants