Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify "--cc=msc" as command line. #2003

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Nov 22, 2022

What does this PR do?

Allow to specify "--cc=msc" as command line (in addition to gcc/clang).

How does this PR change Premake's behavior?

Just the command line to specify cc

Anything else we should know?

Tested on https://github.com/Jarod42/premake-sample-projects/tree/windows_ninja
(More specifically that action run).

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@Jarod42
Copy link
Contributor Author

Jarod42 commented Nov 23, 2022

[ FAILED ] premake_http.http_responsecode
D:/a/premake-core/premake-core/tests/base/test_http.lua:53: expected 502.0 but was 418

Was unrelated to my change, random network issue (502 is Bad Gateway)

BTW test was reversed to have correct error message, i.e:

-		test.isequal(responseCode, 418)
+		test.isequal(418, responseCode)

@Jarod42 Jarod42 mentioned this pull request Nov 28, 2022
6 tasks
@samsinsane samsinsane merged commit e78a880 into premake:master Apr 15, 2023
@Jarod42 Jarod42 deleted the commandline_cc_msc branch April 15, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants