Add support for idirafter flag in GCC/Clang #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
reviewed
Jan 30, 2023
nickclark2016
force-pushed
the
issues/2021
branch
from
ab773db
to
1e65164
Compare
Jarod42
reviewed
Jan 31, 2023
nickclark2016
force-pushed
the
issues/2021
branch
from
1e65164
to
baf145d
Compare
|
For info, UT added in my repo (using this branch), and as expected, core-generators pass, external module generators fail (see premake-sample-projects/actions includedirsafter_test) |
s0600204
added a commit
to s0600204/0ad
that referenced
this pull request
Feb 24, 2023
s0600204
added a commit
to s0600204/0ad
that referenced
this pull request
Apr 11, 2023
samsinsane
approved these changes
Apr 16, 2023
|
@samsinsane : UTs are broken with that merge (due to previous merges). |
|
@Jarod42 thanks for pointing that out, I'll get that fixed up. Sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for the
-idirafterflag with GCC and Clang in the gmake2 and codelite exporters.How does this PR change Premake's behavior?
No changes to the existing Premake behavior. Introduces
includedirsafterAPI. For GCC and Clang utilizing the gmake2 or Codelite exporters, the directories specified byincludedirsafterwill utilize-idirafterflag for includes. For XCode using GCC or Clang, directories defined byincludedirsafterwill be at the end of theSYSTEM_HEADER_SEARCH_PATHSblock. For Visual Studio using MSVC or Clang, directories defined byincludedirsafterwill at the end of theExternalIncludePathelement if in VS2019 or later or in theIncludePathelement if 2017 or before. Similarly, if the MSC toolset is used,/external:Iwill be utilized forincludedirsafterwhen usingmsc-142or newer, or/Iformsc-141or earlier.Anything else we should know?
Closes #2021
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!