Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated actions from v2 to v3 #2064

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

samsinsane
Copy link
Member

@samsinsane samsinsane commented Apr 19, 2023

What does this PR do?

Updates actions from v2 to v3, closes #2063

How does this PR change Premake's behavior?

N/A

Anything else we should know?

N/A

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@Jarod42
Copy link
Contributor

Jarod42 commented Apr 19, 2023

[ FAILED ] premake_http.http_responsecode
.../work/premake-core/premake-core/tests/base/test_http.lua:73: expected 418 but was 504.0

Seems my test robustification was not enough :/ (testing server seems so unreachable during 1 second :-/ )

Copy link
Member

@KyrietS KyrietS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And nothing broke... most impressive, indeed 😄

@samsinsane
Copy link
Member Author

And nothing broke...

Probably why the HTTP tests failed suddenly 😄

@samsinsane samsinsane merged commit 3f1e4f8 into premake:master Apr 20, 2023
@samsinsane samsinsane deleted the ssurtees/actionsUpdate branch April 20, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to update github actions
3 participants