Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VS2022 to list of valid kinds for Android Packaging #2104

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

redorav
Copy link
Collaborator

@redorav redorav commented Jul 1, 2023

What does this PR do?

Adds VS2022 to the list of valid kinds for Android

How does this PR change Premake's behavior?

Removes the warning that happens when trying to add a project of type packaging in VS2022

Anything else we should know?

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016 nickclark2016 merged commit dc8dc0a into master Jul 13, 2023
@nickclark2016
Copy link
Member

In the future, please make changes in a fork instead of the main repo.

@nickclark2016 nickclark2016 deleted the AndroidVS2022 branch July 13, 2023 09:07
@redorav
Copy link
Collaborator Author

redorav commented Jul 13, 2023

Apologies and will do, I did that by accident ironically using Fork (the git UI) and I wasn't sure whether undoing might cause more issues. Thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants