Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the D module due to lack of support #2282

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

samsinsane
Copy link
Member

What does this PR do?

Removes the D module.

How does this PR change Premake's behavior?

No more support for the D language.

Anything else we should know?

This module has blocked the removal of the gmake module for the last 7 years. I was one of the people voting to keep the module, but having looked at the timelines, I have re-evaluated my opinion.

I decided to remove the entire module instead of just the gmake support because this module hasn't received any real changes since 2018, except for once in 2021 (#1658) and once in 2019 (#1298). All other changes were instances of a feature or new value being added to all of the modules in one go, so it's unclear if these changes were correct/compatible or not. This module was only added into core in 2015, which means it has been unsupported for longer than it was supported.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@samsinsane samsinsane force-pushed the ssurtees/removeDModule branch 2 times, most recently from 3a0dc0c to a688055 Compare October 3, 2024 10:38
@tritao
Copy link
Contributor

tritao commented Oct 4, 2024

Sad to see it go as D is actually a pretty cool language, but if does not have any support seems like the way to go.

@nickclark2016
Copy link
Member

At some point it may be worth pulling this into a module, but as I don't use D and have just helped to maintain it from a very high level, I do agree with it's removal from core.

@nickclark2016 nickclark2016 merged commit 74e689f into premake:master Oct 25, 2024
17 checks passed
@samsinsane samsinsane deleted the ssurtees/removeDModule branch October 31, 2024 03:25
noresources pushed a commit to depinxi/premake-core that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants