Add additional tokens to fileconfig and vs2010+. #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsinsane
reviewed
Jan 23, 2017
| @@ -31,7 +31,10 @@ | |||
| ["file.basename"] = { absolute = false, token = "%(Filename)" }, | |||
| ["file.abspath"] = { absolute = true, token = "%(FullPath)" }, | |||
| ["file.relpath"] = { absolute = false, token = "%(Identity)" }, | |||
| ["file.path"] = { absolute = true, token = "%(Identity)" }, | |||
| ["file.path"] = { absolute = false, token = "%(Identity)" }, | |||
There was a problem hiding this comment.
Just want to verify that this should be changed to false?
There was a problem hiding this comment.
Yes, %(Identity) is a relative path in msbuild... and in premake itself, path is an alias for relpath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides us with a workaround for a fix that was made that broke our builds.
#643
we relied on "path" being the "%(RelativeDir)" token in visual studio... obviously wrong, but we relied on it, so we need another way to get there..