Added os touchfile and a workaround for vs2010 reloading #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsinsane
approved these changes
Jun 18, 2017
src/host/os_touchfile.c
Outdated
| const char* dst = luaL_checkstring(L, 1); | ||
|
|
||
| // if destination exist, mark the file as modified | ||
| if (do_isfile(dst)) |
There was a problem hiding this comment.
This takes a lua_State* as the first parameter with the path as the second, I'm guessing you modified this just before pushing?
There was a problem hiding this comment.
Yeah, we have a local change I guess that doesn't have that argument...
I'll fix it in the PR.
vs2010 (and above) has an issue where if the vcxproj file isn't modified but the.vcxproj.filters is modified during premake, then VS doesn't notify the user that the project has changed. This can occur if the only change to a project is with the vpaths. Before this fix, the user would be need to manually unload and reload the project to pick up the change. This VS workaround checks for the case where the vcxproj.filters file is modified but the .vcxproj file is not. At which point premake preforms a touch on the .vcxproj file to trigger the IDE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vs2010 (and above) has an issue where if the vcxproj file
isn't modified but the.vcxproj.filters is modified during
premake, then VS doesn't notify the user that the project has
changed. This can occur if the only change to a project is
with the vpaths. Before this fix, the user would be need to
manually unload and reload the project to pick up the change.
This VS workaround checks for the case where the vcxproj.filters
file is modified but the .vcxproj file is not. At which point
premake preforms a touch on the .vcxproj file to trigger the IDE.