Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed C++17 flag to work with current versions of Clang. #816

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

tvandijck
Copy link
Contributor

17 isn't official yet, both gcc and clang still refer to it as '1z'

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but won't this always be an issue? GCC and Clang will eventually support 17 instead of 1z, but users might still require 1z for their older setups. Perhaps we should additionally create "C++1z" for those use cases? Or maybe more complex Makefiles that determine what is required based on version numbers?

@tvandijck
Copy link
Contributor Author

I think premake, just like cmake should 'detect' what version is currently 'installed' and being used, and decide based on that... until such time flags like this will always be in flux...

We have similar problems with VS2015 Update 1 vs Update 3.... Update 3 has /std:c++14 support, Update 1 does not and gives a warning that it is an unrecognized option. Premake doesn't know, it just generates what we tell it to generate for "vs2015"... Sure we can make actions like vs2015.1, and vs2015.2, etc... but are we really then also going to make things like:

clang38, clang381, clang39, clang391, and for gcc, oh my.... if you go back to 2010 (4.4.3+) we're talking about 41 releases...

it's a huge matrix of x translates to y for any of these compilers, and premake isn't really that good at doing the right thing for any of them, except those that someone actively uses is targetting. So with blizzard as a really active user, fixes like this essentially just target the compilers we use, but we would really like to see a better more sustainable option.

@tvandijck tvandijck merged commit 22cebb4 into premake:master Jun 19, 2017
@tvandijck tvandijck deleted the fix-cpp17-flags branch June 19, 2017 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants