-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move part of the workspace baking up #965
Conversation
@starkos, can you think of any reason why this wouldn't be correct. I don't see any code in the oven.bakeConfigs that actually depends on any output from projects or the bakeChildren. I might be wrong, but I'd like to make this change if at all possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but @starkos should definitely give it a look over before it's merged.
Out of curiosity, what benefits does moving this up provide you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, I wouldn't anticipate any side effects. I'll let you pull the trigger on the merge though, just in case.
So parts of the bakeFiles, I want to refactor (or I already did here) to do the So moving this up, bakes the workspace configs first, allowing you to enumerate them during the project bake.. I may not make much sense, PR incoming.. |
This loop in particular wouldn't work without this change: |
Again, I think this looks fine. I'm hitting "Update branch" to catch it up to master, but feel free to merge when it's ready (if I don't do it first). |
mac is always so far behind... linux + windows are good. |
I know right! There's only a couple of hours a day where there isn't a backlog of macOS builds - they also love performing maintenance on those things all the time. |
Yeah, I wonder if there is an alternative, or a way to provide them with hardware for specific jobs... I don't mind setting up a mac here specifically for those builds, so we get somewhat quicker turn around... |
@starkos, can you think of any reason why this wouldn't be correct.
I don't see any code in the oven.bakeConfigs that actually depends on any output from projects or the bakeChildren.
I might be wrong, but I'd like to make this change if at all possible?