Revert "feat: Adds a key-value endpoint to store the state of dashboa…

…rd filters (apache#17536)" This reverts commit 2f2e8fe.
preset-io · Dec 7, 2021 · 16c6d13 · 16c6d13
1 parent bc56eea
commit 16c6d13
Show file tree

Hide file tree

Showing 22 changed files with 0 additions and 1,037 deletions.
diff --git a/UPDATING.md b/UPDATING.md
@@ -38,13 +38,11 @@ assists people when migrating to a new version.
 - [17539](https://github.com/apache/superset/pull/17539): all Superset CLI commands
   (init, load_examples and etc) require setting the FLASK_APP environment variable
   (which is set by default when .flaskenv is loaded)
-
 ### Deprecations
 
 ### Other
 
 - [16809](https://github.com/apache/incubator-superset/pull/16809): When building the superset frontend assets manually, you should now use Node 16 (previously Node 14 was required/recommended). Node 14 will most likely still work for at least some time, but is no longer actively tested for on CI.
-- [17536](https://github.com/apache/superset/pull/17536): introduced a key-value endpoint to store dashboard filter state. This endpoint is backed by Flask-Caching and the default configuration assumes that the values will be stored in the file system. If you are already using another cache backend like Redis or Memchached, you'll probably want to change this setting in `superset_config.py`. The key is `FILTER_STATE_CACHE_CONFIG` and the available settings can be found in Flask-Caching [docs](https://flask-caching.readthedocs.io/en/latest/).
 
 ## 1.3.0
 

diff --git a/superset/config.py b/superset/config.py
@@ -561,15 +561,6 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
 # Cache for datasource metadata and query results
 DATA_CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "null"}
 
-# Cache for filters state
-FILTER_STATE_CACHE_CONFIG: CacheConfig = {
-    "CACHE_TYPE": "filesystem",
-    "CACHE_DIR": os.path.join(DATA_DIR, "cache"),
-    "CACHE_DEFAULT_TIMEOUT": int(timedelta(days=90).total_seconds()),
-    "CACHE_THRESHOLD": 0,
-    "REFRESH_TIMEOUT_ON_RETRIEVAL": True,
-}
-
 # store cache keys by datasource UID (via CacheKey) for custom processing/invalidation
 STORE_CACHE_KEYS_IN_METADATA_DB = False
 

diff --git a/superset/dashboards/filter_state/__init__.py b/superset/dashboards/filter_state/__init__.py
diff --git a/superset/dashboards/filter_state/api.py b/superset/dashboards/filter_state/api.py
diff --git a/superset/dashboards/filter_state/commands/__init__.py b/superset/dashboards/filter_state/commands/__init__.py
diff --git a/superset/dashboards/filter_state/commands/create.py b/superset/dashboards/filter_state/commands/create.py
diff --git a/superset/dashboards/filter_state/commands/delete.py b/superset/dashboards/filter_state/commands/delete.py