Revert "feat: Virtual dataset duplication (apache#20309)"

This reverts commit 16032ed.

superset-frontend/src/views/CRUD/data/dataset/DatasetList.test.jsx

@@ -41,7 +41,6 @@ const store = mockStore({});
 const datasetsInfoEndpoint = 'glob:*/api/v1/dataset/_info*';
 const datasetsOwnersEndpoint = 'glob:*/api/v1/dataset/related/owners*';
 const datasetsSchemaEndpoint = 'glob:*/api/v1/dataset/distinct/schema*';
-const datasetsDuplicateEndpoint = 'glob:*/api/v1/dataset/duplicate*';
 const databaseEndpoint = 'glob:*/api/v1/dataset/related/database*';
 const datasetsEndpoint = 'glob:*/api/v1/dataset/?*';
 
@@ -64,17 +63,14 @@ const mockUser = {
 };
 
 fetchMock.get(datasetsInfoEndpoint, {
-  permissions: ['can_read', 'can_write', 'can_duplicate'],
+  permissions: ['can_read', 'can_write'],
 });
 fetchMock.get(datasetsOwnersEndpoint, {
   result: [],
 });
 fetchMock.get(datasetsSchemaEndpoint, {
   result: [],
 });
-fetchMock.post(datasetsDuplicateEndpoint, {
-  result: [],
-});
 fetchMock.get(datasetsEndpoint, {
   result: mockdatasets,
   dataset_count: 3,
@@ -185,44 +181,6 @@ describe('DatasetList', () => {
       wrapper.find('[data-test="bulk-select-copy"]').text(),
     ).toMatchInlineSnapshot(`"3 Selected (2 Physical, 1 Virtual)"`);
   });
-
-  it('shows duplicate modal when duplicate action is clicked', async () => {
-    await waitForComponentToPaint(wrapper);
-    expect(
-      wrapper.find('[data-test="duplicate-modal-input"]').exists(),
-    ).toBeFalsy();
-    act(() => {
-      wrapper
-        .find('#duplicate-action-tooltop')
-        .at(0)
-        .find('.action-button')
-        .props()
-        .onClick();
-    });
-    await waitForComponentToPaint(wrapper);
-    expect(
-      wrapper.find('[data-test="duplicate-modal-input"]').exists(),
-    ).toBeTruthy();
-  });
-
-  it('calls the duplicate endpoint', async () => {
-    await waitForComponentToPaint(wrapper);
-    await act(async () => {
-      wrapper
-        .find('#duplicate-action-tooltop')
-        .at(0)
-        .find('.action-button')
-        .props()
-        .onClick();
-      await waitForComponentToPaint(wrapper);
-      wrapper
-        .find('[data-test="duplicate-modal-input"]')
-        .at(0)
-        .props()
-        .onPressEnter();
-    });
-    expect(fetchMock.calls(/dataset\/duplicate/)).toHaveLength(1);
-  });
 });
 
 jest.mock('react-router-dom', () => ({

superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx

@@ -69,7 +69,6 @@ import {
   PASSWORDS_NEEDED_MESSAGE,
   CONFIRM_OVERWRITE_MESSAGE,
 } from './constants';
-import DuplicateDatasetModal from './DuplicateDatasetModal';
 
 const FlexRowContainer = styled.div`
   align-items: center;
@@ -120,11 +119,6 @@ type Dataset = {
   table_name: string;
 };
 
-interface VirtualDataset extends Dataset {
-  extra: Record<string, any>;
-  sql: string;
-}
-
 interface DatasetListProps {
   addDangerToast: (msg: string) => void;
   addSuccessToast: (msg: string) => void;
@@ -163,9 +157,6 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
   const [datasetCurrentlyEditing, setDatasetCurrentlyEditing] =
     useState<Dataset | null>(null);
 
-  const [datasetCurrentlyDuplicating, setDatasetCurrentlyDuplicating] =
-    useState<VirtualDataset | null>(null);
-
   const [importingDataset, showImportModal] = useState<boolean>(false);
   const [passwordFields, setPasswordFields] = useState<string[]>([]);
   const [preparingExport, setPreparingExport] = useState<boolean>(false);
@@ -187,7 +178,6 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
   const canEdit = hasPerm('can_write');
   const canDelete = hasPerm('can_write');
   const canCreate = hasPerm('can_write');
-  const canDuplicate = hasPerm('can_duplicate');
   const canExport =
     hasPerm('can_export') && isFeatureEnabled(FeatureFlag.VERSIONED_EXPORT);
 
@@ -251,10 +241,6 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
         ),
       );
 
-  const openDatasetDuplicateModal = (dataset: VirtualDataset) => {
-    setDatasetCurrentlyDuplicating(dataset);
-  };
-
   const handleBulkDatasetExport = (datasetsToExport: Dataset[]) => {
     const ids = datasetsToExport.map(({ id }) => id);
     handleResourceExport('dataset', ids, () => {
@@ -411,8 +397,7 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
           const handleEdit = () => openDatasetEditModal(original);
           const handleDelete = () => openDatasetDeleteModal(original);
           const handleExport = () => handleBulkDatasetExport([original]);
-          const handleDuplicate = () => openDatasetDuplicateModal(original);
-          if (!canEdit && !canDelete && !canExport && !canDuplicate) {
+          if (!canEdit && !canDelete && !canExport) {
             return null;
           }
           return (
@@ -471,32 +456,16 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
                   </span>
                 </Tooltip>
               )}
-              {canDuplicate && original.kind === 'virtual' && (
-                <Tooltip
-                  id="duplicate-action-tooltop"
-                  title={t('Duplicate')}
-                  placement="bottom"
-                >
-                  <span
-                    role="button"
-                    tabIndex={0}
-                    className="action-button"
-                    onClick={handleDuplicate}
-                  >
-                    <Icons.Copy />
-                  </span>
-                </Tooltip>
-              )}
             </Actions>
           );
         },
         Header: t('Actions'),
         id: 'actions',
-        hidden: !canEdit && !canDelete && !canDuplicate,
+        hidden: !canEdit && !canDelete,
         disableSortBy: true,
       },
     ],
-    [canEdit, canDelete, canExport, openDatasetEditModal, canDuplicate],
+    [canEdit, canDelete, canExport, openDatasetEditModal],
   );
 
   const filterTypes: Filters = useMemo(
@@ -656,10 +625,6 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
     setDatasetCurrentlyEditing(null);
   };
 
-  const closeDatasetDuplicateModal = () => {
-    setDatasetCurrentlyDuplicating(null);
-  };
-
   const handleDatasetDelete = ({ id, table_name: tableName }: Dataset) => {
     SupersetClient.delete({
       endpoint: `/api/v1/dataset/${id}`,
@@ -695,30 +660,6 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
     );
   };
 
-  const handleDatasetDuplicate = (newDatasetName: string) => {
-    if (datasetCurrentlyDuplicating === null) {
-      addDangerToast(t('There was an issue duplicating the dataset.'));
-    }
-
-    SupersetClient.post({
-      endpoint: `/api/v1/dataset/duplicate`,
-      postPayload: {
-        base_model_id: datasetCurrentlyDuplicating?.id,
-        table_name: newDatasetName,
-      },
-    }).then(
-      () => {
-        setDatasetCurrentlyDuplicating(null);
-        refreshData();
-      },
-      createErrorHandler(errMsg =>
-        addDangerToast(
-          t('There was an issue duplicating the selected datasets: %s', errMsg),
-        ),
-      ),
-    );
-  };
-
   return (
     <>
       <SubMenu {...menuData} />
@@ -753,11 +694,6 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
           show
         />
       )}
-      <DuplicateDatasetModal
-        dataset={datasetCurrentlyDuplicating}
-        onHide={closeDatasetDuplicateModal}
-        onDuplicate={handleDatasetDuplicate}
-      />
       <ConfirmStatusChange
         title={t('Please confirm')}
         description={t(