Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move header to separate file #107

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

AAfghahi
Copy link

@AAfghahi AAfghahi commented Jun 9, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (ch16648_headerSteps@eb53d28). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             ch16648_headerSteps     #107   +/-   ##
======================================================
  Coverage                       ?   77.50%           
======================================================
  Files                          ?      966           
  Lines                          ?    49644           
  Branches                       ?     6304           
======================================================
  Hits                           ?    38478           
  Misses                         ?    10963           
  Partials                       ?      203           
Flag Coverage Δ
javascript 72.28% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb53d28...08571d4. Read the comment docs.

@AAfghahi AAfghahi changed the title move header to separate file fix: move header to separate file Jun 9, 2021
@AAfghahi AAfghahi merged this pull request into ch16648_headerSteps Jun 9, 2021
@AAfghahi AAfghahi deleted the elizabeth/move-header branch June 9, 2021 15:53
AAfghahi added a commit that referenced this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants