feat(experimental): keep Store internal and add Tablename method #624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Store interface,
Tablename() string
method to ensure ALL store implementations at least have it set. I don't think the goose package actually needs it, but if we're decoupling the store from the provider, we should have a single check for this in the provider constructor.InsertOrDelete
intoInsert
/Delete
and have insert take aInsertRequest
. This way we can future-proof the ability to pass additional information to Store implementations without breaking the contract.This would potentially allow us to expand the goose table in a backwards-compatible way, #422 #288
In addition,
WithStore
option to support custom implementations.