Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Set boolean value to 0 if the position is null
Setting the actual value to a random 0 or 1 is rather not intuitive and error prone. We may expect the boolean (or integer) value to be set to 0 if the position is null in some places across the code Benchmarks Before: Benchmark (typeSignature) (withNulls) Mode Cnt Score Error Units BenchmarkBatchStreamReadersWithZstd.readBlocksWithJni boolean PARTIAL avgt 20 0.022 ± 0.002 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithJni tinyint PARTIAL avgt 20 0.022 ± 0.003 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithJni smallint PARTIAL avgt 20 0.075 ± 0.006 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithJni integer PARTIAL avgt 20 0.107 ± 0.010 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithJni bigint PARTIAL avgt 20 0.167 ± 0.010 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithoutJni boolean PARTIAL avgt 20 0.023 ± 0.003 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithoutJni tinyint PARTIAL avgt 20 0.022 ± 0.004 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithoutJni smallint PARTIAL avgt 20 0.091 ± 0.006 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithoutJni integer PARTIAL avgt 20 0.122 ± 0.008 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithoutJni bigint PARTIAL avgt 20 0.199 ± 0.011 s/op After: Benchmark (typeSignature) (withNulls) Mode Cnt Score Error Units BenchmarkBatchStreamReadersWithZstd.readBlocksWithJni boolean PARTIAL avgt 20 0.022 ± 0.004 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithJni tinyint PARTIAL avgt 20 0.021 ± 0.004 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithJni smallint PARTIAL avgt 20 0.073 ± 0.006 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithJni integer PARTIAL avgt 20 0.103 ± 0.011 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithJni bigint PARTIAL avgt 20 0.172 ± 0.010 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithoutJni boolean PARTIAL avgt 20 0.022 ± 0.003 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithoutJni tinyint PARTIAL avgt 20 0.021 ± 0.004 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithoutJni smallint PARTIAL avgt 20 0.093 ± 0.010 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithoutJni integer PARTIAL avgt 20 0.123 ± 0.011 s/op BenchmarkBatchStreamReadersWithZstd.readBlocksWithoutJni bigint PARTIAL avgt 20 0.196 ± 0.011 s/op
- Loading branch information