Use different columns for control and test session properties

prestodb · Dec 4, 2019 · e91519a · e91519a
1 parent f074d63
commit e91519a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/presto-docs/src/main/sphinx/installation/verifier.rst b/presto-docs/src/main/sphinx/installation/verifier.rst
@@ -22,12 +22,13 @@ Create a MySQL database with the following table and load it with the queries yo
         control_query text NOT NULL,
         control_username varchar(256) DEFAULT NULL,
         control_password varchar(256) DEFAULT NULL,
-        session_properties_json text DEFAULT NULL,
+        control_session_properties text DEFAULT NULL,
         test_catalog varchar(256) NOT NULL,
         test_schema varchar(256) NOT NULL,
         test_query text NOT NULL,
         test_username varchar(256) DEFAULT NULL,
-        test_password varchar(256) DEFAULT NULL)
+        test_password varchar(256) DEFAULT NULL,
+        test_session_properties text DEFAULT NULL)
 
 Next, create a properties file to configure the verifier:
 

diff --git a/presto-verifier/src/main/java/com/facebook/presto/verifier/source/VerifierDao.java b/presto-verifier/src/main/java/com/facebook/presto/verifier/source/VerifierDao.java
@@ -35,12 +35,13 @@ public interface VerifierDao
             "  control_query text NOT NULL,\n" +
             "  control_username varchar(256) DEFAULT NULL,\n" +
             "  control_password varchar(256) DEFAULT NULL,\n" +
+            "  control_session_properties text DEFAULT NULL,\n" +
             "  test_catalog varchar(256) NOT NULL,\n" +
             "  test_schema varchar(256) NOT NULL,\n" +
             "  test_query text NOT NULL,\n" +
             "  test_username varchar(256) DEFAULT NULL,\n" +
             "  test_password varchar(256) DEFAULT NULL,\n" +
-            "  session_properties_json text DEFAULT NULL)")
+            "  test_session_properties text DEFAULT NULL)")
     void createVerifierQueriesTable(@Define("table_name") String tableName);
 
     @SqlQuery("SELECT\n" +
@@ -51,13 +52,13 @@ public interface VerifierDao
             "  control_schema,\n" +
             "  control_username,\n" +
             "  control_password,\n" +
-            "  session_properties_json test_session_properties,\n" +
+            "  control_session_properties,\n" +
             "  test_query,\n" +
             "  test_catalog,\n" +
             "  test_schema,\n" +
             "  test_username,\n" +
             "  test_password,\n" +
-            "  session_properties_json control_session_properties\n" +
+            "  test_session_properties\n" +
             "FROM\n" +
             "  <table_name>\n" +
             "WHERE\n" +