Enable prepared statement product tests for Presto JDBC driver #10870
Conversation
| assertThat(QueryResult.forResultSet(statement.executeQuery(executeSql + "NULL"))) | ||
| .hasNoRows(); | ||
| assertThat(QueryResult.forResultSet(statement.executeQuery(executeSql + 2))) | ||
| .hasNoRows(); | ||
| } | ||
|
|
||
| @Test(groups = {JDBC, SIMBA_JDBC}) |
There was a problem hiding this comment.
I think this tests no longer needs to be in both groups. I would remove SIMBA_JDBC and keep only JDBC.
Their use case is to run tempto with all JDBC tests but these that are SIMBA_JDBC (or PRESTO_JDBC depending on used driver). As I understand here we expect both drivers to be compatible.
There was a problem hiding this comment.
@kokosing when testing simba, do we run sth like -g JDBC -x PRESTO_JDBC or -g SIMBA_JDBC ?
There was a problem hiding this comment.
-g ldap,jdbc,simba_jdbc -x presto_jdbc,mysql,quarantine
There was a problem hiding this comment.
or
-g smoke,simba_jdbc,jdbc -x presto_jdbc,ldap,mysql,quarantine
Generally rule is the same
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
No description provided.