-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize array_join by supporting PROVIDED_BLOCKBUILDER convention #13874
Conversation
4857cfd
to
22b044f
Compare
Benchmark shows over 10% improvements. Before
After
|
See #9638 and #12166 for context. cc @oerling , we once talked about allowing scalar function to directly write to output buffer (to avoid copy data for struct types). The framework is implemented but not function is yet using it. @kaikalur recently also observed such inefficiency when optimizing user's query, so here is an example about how to use it :) .
|
I realized the benchmark is over |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Benchmark shows over 10% improvements. Before ``` Benchmark Mode Cnt Score Error Units BenchmarkArrayJoin.benchmark avgt 60 152.954 ± 1.246 ns/op ``` After ``` Benchmark Mode Cnt Score Error Units BenchmarkArrayJoin.benchmark avgt 60 134.558 ± 2.078 ns/op ```
Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.