Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential native memory leak #8531

Closed
wants to merge 1 commit into from
Closed

Fix potential native memory leak #8531

wants to merge 1 commit into from

Conversation

nezihyigitbasi
Copy link
Contributor

@nezihyigitbasi nezihyigitbasi commented Jul 17, 2017 •
edited
Loading

keySectionOutput.writeBytes() can throw resulting in a memory leak.

@nezihyigitbasi
Make sure to close keySectionOutput
802d875 
keySectionOutput.writeBytes() can throw resulting in a memory leak.
@nezihyigitbasi nezihyigitbasi changed the title Make sure to close keySectionOutput Fix potential native memory leak Jul 17, 2017
@nezihyigitbasi nezihyigitbasi requested a review from dain July 19, 2017 17:21
@dain dain assigned nezihyigitbasi and unassigned dain Jul 19, 2017
@nezihyigitbasi
Copy link
Contributor Author

Merged.

@nezihyigitbasi nezihyigitbasi deleted the more-leak-fixes branch July 24, 2017 18:46
@highker highker mentioned this pull request Sep 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dain dain dain approved these changes

Assignees

@nezihyigitbasi nezihyigitbasi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nezihyigitbasi @dain @facebook-github-bot