Align output to buffer size in rcfile writer #9001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highker
force-pushed
the
rcfile
branch
2 times, most recently
from
9cf1768
to
ab2c3e3
Compare
electrum
reviewed
Sep 19, 2017
| length -= flushLength; | ||
| } | ||
|
|
||
| // line up the chuck to buffer size and flush directly to OutputStream |
highker
force-pushed
the
rcfile
branch
2 times, most recently
from
a188bec
to
887e3a9
Compare
dain
suggested changes
Sep 19, 2017
|
|
||
| // line up the chunk to chunk size and flush directly to OutputStream | ||
| int flushLength = length - length % CHUNK_SIZE; | ||
| for (int i = 0; i < flushLength / CHUNK_SIZE; i++) { |
There was a problem hiding this comment.
I think it would be simpler to do:
while (length <= CHUNK_SIZE) {
writeToOutputStream(source, sourceIndex, CHUNK_SIZE);
sourceIndex += CHUNK_SIZE;
length -= CHUNK_SIZE;
}then after the loop you don't need to touch length of bufferOffset.
| } | ||
|
|
||
| // line up the chunk to chunk size and flush directly to OutputStream | ||
| int flushLength = length - length % CHUNK_SIZE; |
| // test some different buffer sizes | ||
| for (int bufferSize : new int[] {4096, 4345, 65535, 65536, 65537, 100000}) { | ||
| // check byte array version | ||
| ByteArrayOutputStream byteOutputStream = new ByteArrayOutputStream(length); |
There was a problem hiding this comment.
Make a subclass that captures the flush sizes and then validate you don't get flushes > 4k
dain
approved these changes
Sep 19, 2017
| } | ||
|
|
||
| // buffer the remaining data |
There was a problem hiding this comment.
wrapper this with if (length != 0)
| } | ||
|
|
||
| // buffer the remaining data |
Flushing data in arbitrary sizes can be a problem for memory fragmentation. This is generally fine unless the output stream can allocate native memory (e.g., gzip streams). Native memory allocator may not be able to compact fragmentation, which can cause native memory OOM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flushing data in arbitrary sizes can be a problem for memory
fragmentation. This is generally fine unless the output stream can
allocate native memory (e.g., gzip streams). Native memory allocator may
not be able to compact fragmentation, which can cause native memory OOM.
Resolves #8993