Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code_8042B34 + static inline fixes #227

Merged
merged 10 commits into from
Oct 15, 2024
Merged

code_8042B34 + static inline fixes #227

merged 10 commits into from
Oct 15, 2024

Conversation

DizzyEggg
Copy link
Contributor

@DizzyEggg DizzyEggg commented Oct 9, 2024 •
edited
Loading

No description provided.

@DizzyEggg DizzyEggg marked this pull request as ready for review October 13, 2024 13:42
@DizzyEggg
Copy link
Contributor Author

Ready for review.
Imporant PR, because it fixes a bunch of non/fake/weird matches by using static inlines. I believe they'll solve most of the compiler weirdness when failing to match.

Btw, CI broke I think. The checks need to re-run

@DizzyEggg DizzyEggg changed the title code_8042B34 code_8042B34 + static inline fixes Oct 13, 2024
@SethBarberee
Copy link
Collaborator

Getting errors on CI about libpng. Update the workflow file with libpng-dev like pokeemerald and let's see if that helps. I'm thinking there was an update with the container and it doesn't install libpng by default anymore.

@SethBarberee
Copy link
Collaborator

Rebase and CI should be good again.

@DizzyEggg
Copy link
Contributor Author

Rebase and CI should be good again.

Yup, it's good now

@AnonymousRandomPerson AnonymousRandomPerson merged commit a610215 into pret:master Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnonymousRandomPerson AnonymousRandomPerson AnonymousRandomPerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DizzyEggg @SethBarberee @AnonymousRandomPerson