Rename symbols and files according to Time/Darkness prototype strings #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonymousRandomPerson
requested changes
Dec 28, 2023
|
Addresses are now removed from the file names and comments have been added. |
AnonymousRandomPerson
approved these changes
Dec 29, 2023
UsernameFodder
pushed a commit
to UsernameFodder/pmdsky-debug
that referenced
this pull request
Dec 29, 2023
…#236) Sync symbol names from pret/pmd-sky#52 All symbols of known decompiled functions were renamed according to strings found in the Time/Darkness prototypes. Functions with unknown exact names were named to be consistent in context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All symbols of known decompiled functions were renamed according to strings found in the prototypes. Functions with unknown exact names were named to be consistent in context. Some referenced asm symbols and several source and header files were also renamed. Some c files have an address appended to signify that the first function does not yet align with the file boundary. A decomp of an unknown text sprite init function at the beginning of overlay 29 (in poly_text.c) is also included.