Decompile dungeon code #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/overlay_29_02338604.c
Outdated
| void SetShouldBoostHiddenStairsSpawnChance(u8 should_boost) | ||
| { | ||
| #ifdef JAPAN | ||
| DUNGEON_PTR[0]->unknown_file_buffer_0x12162[0x91f]=should_boost; |
There was a problem hiding this comment.
This is likely a variable for boosting the hidden stairs chance that is not yet documented in the dungeon struct. It seems unlikely that this info would be stored in a file buffer, or within an array for that matter. Perhaps we can shorten the file buffer, add the new variable, and add another filler array to ensure that the dungeon struct remains the same size.
There was a problem hiding this comment.
Looks like I did my math wrong and overran the end of this array- it's actually the later (appropriately-named) variable boost_hidden_stairs_spawn_chance. Fixed.
AnonymousRandomPerson
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the dungeon struct is imported, let's work on some of that code!