Fix jQuery 1.x never calling complete #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you show some of the other strategies you tried? This add jQuery as a dependency, when there isn't a reason to. |
| @@ -7,6 +7,7 @@ var appearsBrowserified = typeof self !== 'undefined' && | |||
|
|
|||
| var RouteRecognizer = appearsBrowserified ? require('route-recognizer') : self.RouteRecognizer; | |||
| var FakeXMLHttpRequest = appearsBrowserified ? require('fake-xml-http-request') : self.FakeXMLHttpRequest; | |||
| var jQuery = appearsBrowserified ? require('jquery') : self.jQuery; | |||
There was a problem hiding this comment.
This feels wrong for projects that don't have jQuery as a dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85.
Tried to find a way to check for this case without referring to jQuery directly but it can't really be avoided.
Tests should ideally be ran against jQuery 1.x and 2.x but that is going to require some project restructuring.
Two of the async/synchronous tests fail with jQuery 1.x for some reason. It seems like a difference in the way 1.x interacts with XMLHttpRequest. I think it may need to be addressed upstream (in FakeXMLHttpRequest). Any ideas @trek or @mike-north?