Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pretender.js #114

Closed
wants to merge 3 commits into from

Conversation

olivierlesnicki
Copy link
Contributor

fix #85

@trek
Copy link
Member

trek commented Sep 27, 2015

Can you check my CI is failing?

@thijsvdanker
Copy link

CI was failing because extracting FakeXMLHttpRequest gave an error

bower invalid-meta  fake-xml-http-request is missing "ignore" entry in bower.json

And pretender.js fails when requiring 'fake-xml-http-request'.

I was having issues with callbacks not being called as well, even when using jQuery 2.x.
Using @olivierlesnicki PR fixed the issue for me, but I have too little knowledge of the internals to say if it's good.

@thijsvdanker
Copy link

@trek Can you run CI again to see if it was indeed a hickup?

@olivierlesnicki
Copy link
Contributor Author

@thijsvdanker I've triggered the CI again

@trek
Copy link
Member

trek commented Nov 24, 2015

CI is still failing, sadly.

@thijsvdanker
Copy link

This time CI actually fails because of the patch. I can reproduce the failing test with running npm test locally.
Reverting the patch makes the test pass again.

@john-kurkowski
Copy link

Should this be closed in favor of #130? That one fixes the same issue, performs refactoring, and tests pass. All it needs is to add jQuery 1.x to the test suite.

@olivierlesnicki
Copy link
Contributor Author

@john-kurkowski agreed

@trek
Copy link
Member

trek commented Dec 3, 2015

Closing in favor of #130

@trek trek closed this Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jQuery 1.x with passthrough
4 participants