-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pretender.js #114
Update pretender.js #114
Conversation
Can you check my CI is failing? |
CI was failing because extracting FakeXMLHttpRequest gave an error
And pretender.js fails when requiring 'fake-xml-http-request'. I was having issues with callbacks not being called as well, even when using jQuery 2.x. |
@trek Can you run CI again to see if it was indeed a hickup? |
@thijsvdanker I've triggered the CI again |
CI is still failing, sadly. |
This time CI actually fails because of the patch. I can reproduce the failing test with running |
Should this be closed in favor of #130? That one fixes the same issue, performs refactoring, and tests pass. All it needs is to add jQuery 1.x to the test suite. |
@john-kurkowski agreed |
Closing in favor of #130 |
fix #85