Avoid setting QUnit.module.exports = Pretender.
#156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `QUnit` along with `Pretender`, the UMD style that we were previously using would assign an `.exports` property to the `QUnit.module` method (which is present in QUnit 1.x as `self.module` also). This changes to check that we are actually in a node-like environment (where `exports === module.exports`) before setting `module.exports`.
|
@rwjblue is this PR still relevant? from my recent journeys it seems that the current Pretender releases don't have any issues with QUnit running in parallel anymore |
|
@Turbo87 - It is relevant when using QUnit 1.x, but not 2.x (since 2.x doesn't set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
QUnitalong withPretender, the UMD style that we were previously using would assign an.exportsproperty to theQUnit.modulemethod (which is present in QUnit 1.x asself.modulealso). This changes to check that we are actually in a node-like environment (whereexports === module.exports) before settingmodule.exports.