-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: prettier.resolveConfig.sync is not a function #105
Comments
This commit is causing this error: prettier/prettier-eslint@e39719e the function |
Could you delete your |
I might be wrong, but this is the last commit for the prettier build: https://github.com/prettier/prettier/blob/c3506198c007e6667975b3dbf958b8b06550f4a8/website/static/lib/index.js there is no |
@kentcdodds I don't think that the .... I also just upgraded to node 8.4 and have the same issues with a clean install. |
Emptied my |
Ah yes, well that's a problem... cc @robwise I suggest locking down to I'm not using |
The eslint folks keeps insisting eslint is much more than a prettifier. I love to use both. Your tool combines them nicely. |
I use both as well, but I don't use eslint for formatting, I use it for catching bugs that cannot be autofixed 😄 I'm glad you like my tool though! |
double oops, sorry I totally didn't realize that wasn't part of the original resolveConfig release, I just read it in the manual and didn't even think to check |
Just upgraded from 4.1.1 and the error occurred, seems 4.1.1 working fine without this error. Also 4.3.1 produce the very same error. |
prettier-1.6.2 is (which will include prettier/prettier#2722) is about to be released faily soon, see prettier/prettier#2804. |
prettier 1.7.0 is out. They had to upgrade to a minor version. |
Thanks! |
shouln't we bump the depenency on prettier-eslint here in cli? |
I upgraded prettier to 1.7.0 and nothing happened. What's wrong? Any idea? |
In my case I had a yarn.lock preventing the update. I had to remove it. |
My mistake. In the project, there was an old version... |
It looks like there is a regression in 4.3.2:
This only happens with
version 4.3.2, not with 4.3.1versions 4.3.2 and 4.3.1, not with 4.3.0.It also happens without a
.prettierrc
file.prettier-eslint-cli
version: 4.3.2prettier-eslint
version: 8.0.0eslint
version: 4.6.1The text was updated successfully, but these errors were encountered: