Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade prettier to 1.7.0 #125

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Upgrade prettier to 1.7.0 #125

merged 2 commits into from
Sep 14, 2017

Conversation

ppvg
Copy link
Contributor

@ppvg ppvg commented Sep 14, 2017

Upgrade prettier to 1.7.0 to help fix prettier/prettier-eslint-cli#105.

Some tests were (already) failing with:

JSONError: JSON Error in /Users/ppvg/github/prettier-eslint/mock/package.json:
Unexpected token 'v' at 1:1
var fake = true
^

So the fs mock now matches on filename and returns either the original fake or a fake package.json. I'm not sure whether that's considered too ugly of a hack.

@codecov-io
Copy link

codecov-io commented Sep 14, 2017

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #125   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         191    191           
  Branches       32     32           
=====================================
  Hits          191    191

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c4ba4...0b486fa. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks!

@kentcdodds kentcdodds merged commit 92dc149 into prettier:master Sep 14, 2017
@ppvg ppvg deleted the prettier-1.7.0 branch September 14, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: prettier.resolveConfig.sync is not a function
3 participants