-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rxjs import #119
Fix rxjs import #119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 108 108
Branches 14 14
=====================================
Hits 108 108
Continue to review full report at Codecov.
|
Thanks for this. I'll have to do some testing for backwards compatibility, I'm hoping I can get it merged tomorrow. |
Seems like there's a breaking change in rxjs Let's hold off until tomorrow to see if they can fix this. |
if you change the import to |
I was hoping that was the case. I'll have a few hours soon to work on these packages. So I expect to release a new version later tonight. |
Merged in 239de8f. |
Where i need to change @nataly87s Please let me know. in my code i dont have any import {observable} they are all coming from nodeModules itself. That's why i confused. Thanks in advance. |
@SivaPrasanna45 You should only need to update this package to get the fix. |
@zimme I have already updated packages itself, in case need to update what i need to update. |
What:
rxjs
uses named exports, butprettier-eslint-cli
imports it as adefault
.Why:
prettier-eslint-cli
doesn't work because it throws with aTypeError: Cannot read property 'Observable' of undefined
.How: By replacing a default import with a wildcard one.
Tested against
rxjs@5.3.0
andrxjs@5.5+
.