v3 - Drop support for node 12, simplify recommended config in light of stylelint v15 deprecations #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
v3
branch
8 times, most recently
from
a401523 to
055401d
Compare
BPScott
changed the title
- Drop support for node 12 - Run tests using stylelint v15 - Update recommended config to only enable the prettier/prettier rule. It is now up to consumers to enable stylelint-config-prettier if they desire as stylelint v15 deprecates all the rules that stylelint-config-prettier disabled - Tweak expected test output to account for error counts - Tweak e2e test config to account for changes in css-in-js behaviour
This was referenced Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for v3 of the plugin.
stylelint-prettier/recommendedconfig to no longer try to include thestylelint-config-prettierconfig, as will not be needed as people move to stylelint 15 and stop using the deprecated stylistic rules.v2 of
stylelint-prettierworked great when using Stylelint v15, however retaining test support for node 12, and stylelint v15 at the same time isn't worth the complication. It's much easier just to drop node 12 support.