fix: remove auto-add drag connector (#163)

prevwong · Jan 22, 2021 · 60a600a · 60a600a
1 parent 4a8126d
commit 60a600a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/packages/slate/src/extend/editable/Element.tsx b/packages/slate/src/extend/editable/Element.tsx
@@ -11,15 +11,26 @@ const RenderSlateElement = ({
   attributes,
   children,
   renderElement,
+  drag,
 }) => {
   const { type } = useEditor((state) => ({
     type: state.options.resolver[element.type],
   }));
 
-  const render = React.createElement(type, { element, children, attributes });
+  const render = React.createElement(type, {
+    element,
+    children,
+    attributes,
+    drag,
+  });
 
   if (renderElement) {
-    return React.createElement(renderElement, { render, element });
+    return React.createElement(renderElement, {
+      render,
+      element,
+      attributes,
+      drag,
+    });
   }
 
   return render;
@@ -61,7 +72,6 @@ export const Element = ({ attributes, children, element, renderElement }) => {
     }
 
     connect(dom, id);
-    drag(dom, id);
 
     if (!enabled) {
       dom.setAttribute('contenteditable', false);
@@ -79,6 +89,13 @@ export const Element = ({ attributes, children, element, renderElement }) => {
           element={element}
           attributes={attributes}
           children={children}
+          drag={(dom) => {
+            if (!exists) {
+              return;
+            }
+
+            drag(dom, id);
+          }}
         />
       }
     />

diff --git a/packages/slate/src/extend/editable/RenderEditable.tsx b/packages/slate/src/extend/editable/RenderEditable.tsx
@@ -18,7 +18,6 @@ export const RenderEditable = ({ as, children, attributes }) => {
     }
 
     connectors.connect(dom, slateNodeId);
-    connectors.drag(dom, slateNodeId);
   });
 
   return React.createElement(as || DefaultRenderEditable, {